Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more benchmarks #122

Open
radumarias opened this issue Aug 5, 2024 · 5 comments · May be fixed by #262
Open

Add more benchmarks #122

radumarias opened this issue Aug 5, 2024 · 5 comments · May be fixed by #262
Assignees
@nchristiann
Labels
good first issue Good for newcomers tests

Comments

@radumarias
Copy link
Member

radumarias commented Aug 5, 2024 •
edited
Loading

Add more benchmarks using criterion (also migrate existing ones to criterion) and publish them to https://bencher.dev to catch any degrading changes.
Also integrate the run in check-before-push scripts so we catch any degrading performance changes.

https://bencher.dev/?utm_source=the+new+stack&utm_medium=referral&utm_content=inline-mention&utm_campaign=tns+platform

black_box on the input

Sample

Image
@radumarias radumarias added this to rencfs Jun 8, 2024
@radumarias radumarias converted this from a draft issue Aug 5, 2024
@radumarias radumarias added tests good first issue Good for newcomers labels Aug 5, 2024
@radumarias radumarias moved this to Todo in rencfs Aug 5, 2024
@radumarias radumarias changed the title Benchmarks Add more benchmarks Nov 14, 2024
@nchristiann nchristiann self-assigned this Nov 22, 2024
@radumarias
Copy link
Member Author

@nchristiann check links in desc for a sample

@radumarias radumarias moved this from Todo to In Progress in rencfs Dec 2, 2024
@radumarias
Copy link
Member Author

radumarias commented Dec 2, 2024 •
edited
Loading

@nchristiann how is it going with this?

@radumarias
Copy link
Member Author

@nchristiann any progress on this?

@nchristiann
Copy link
Collaborator

@nchristiann any progress on this?

Haven't made much progress but looking into it

@radumarias
Copy link
Member Author

@nchristiann how is it going with this?

This was referenced Dec 16, 2024
Open
Closed
@radumarias radumarias linked a pull request Dec 16, 2024 that will close this issue
Add more benchmarks #122 #262
Open
radumarias added a commit to nchristiann/rencfs that referenced this issue Dec 16, 2024
@radumarias
[xoriors#122] Create utils for running bench with criterion that uses…
b6381f4 
… fs and fixed the ones migrated to criterion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nchristiann nchristiann

Labels
good first issue Good for newcomers tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more benchmarks #122 nchristiann/rencfs
2 participants
@radumarias @nchristiann