Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give up at some point #12

Open
Zash opened this issue Nov 4, 2022 · 3 comments
Open

Give up at some point #12

Zash opened this issue Nov 4, 2022 · 3 comments

Comments

@Zash
Copy link
Contributor

Zash commented Nov 4, 2022

  1. Hack around a bit on testxmpp
  2. Wait 6 months
  3. Hack around a bit on testxmpp
  4. Observe that it's still trying a failed target from 6 months ago (IPv6-only targets #11)

Trying tests again is good, but unless it gives up at some point the number of failed and retrying tests will accumulate and likely run into some sort of limit eventually.

@guusdk
Copy link
Contributor

guusdk commented Oct 11, 2024

Is a quick and dirty approach to a solve for this to check for 'creation_time' at or near https://github.com/xmpp-observatory/testxmpp/blob/master/testxmpp/coordinator/tasks.py#L72 ?

Alternatively, can we get away with simply never retrying a scan if it fails for whatever reason?

@root021
Copy link

root021 commented Oct 12, 2024

It has been a while since I was hacking away at this, but I tried something similar, and it still seemed to retry failed tasks. I would need to recheck exactly what I have tried, though, as I took multiple different approaches to various limits.

@guusdk
Copy link
Contributor

guusdk commented Oct 12, 2024

Is the retry functionality critical for operation? If this is difficult to get right, and also blocking us from moving forwards somewhat, maybe we should consider introducing a simple "sorry, something failed - please try again later" message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants