Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float canvas updates #2448

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Float canvas updates #2448

wants to merge 9 commits into from

Conversation

ChrisBarker-NOAA
Copy link

@ChrisBarker-NOAA ChrisBarker-NOAA commented Aug 21, 2023 •
edited
Loading

Fixed few bugs for newer wxPython, numpy and Python.

Tested with:

  • Python 3.10
  • numpy 1.25
  • wxMac OS-X 11.7.9

Fixes #2320, #2331, #1824

Also got many of the samples working, and cleaned up a bunch of formatting.

I only touched FloatCanvas code.

This was referenced Aug 21, 2023
Open
Open
@ChrisBarker-NOAA
Copy link
Author

NOTE: I was getting segfaults on exit if there was a wx.Overlay still around. But having it deleted in a del method didn't do it -- I had to do a real kludge to fix it -- see:

floatcanvas.utilities.GUI.py lines 123-138

@ChrisBarker-NOAA ChrisBarker-NOAA mentioned this pull request Aug 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canvas.AddArrow from FloatCanvas does not work with WxPython 4.2.0 demo
3 participants
@ChrisBarker-NOAA @swt2c @PythonCHB