Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patch to update grumphp git hook from lando to DDEV aware #7

Closed
hkirsman opened this issue Feb 23, 2024 · 0 comments
Closed

Add patch to update grumphp git hook from lando to DDEV aware #7

hkirsman opened this issue Feb 23, 2024 · 0 comments

Comments

@hkirsman
Copy link
Collaborator

We have this in all of our projects:

grumphp:
git_hook_variables:
EXEC_GRUMPHP_COMMAND: lando php

If we start using DDEV, it would always run Lando on git commit.

For now I've created this. More info here wunderio/drupal-project#393
grumphp:
git_hook_variables:
EXEC_GRUMPHP_COMMAND: "[ -d .ddev/traefik/ ] && GRUMPHP_COMMAND='ddev php' || GRUMPHP_COMMAND='lando php' && $GRUMPHP_COMMAND"

I think the ideal solution would be that this package replaces the line in grumph.yml
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
6f3c293
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
969170d
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
b762036
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
a55cb75
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
a7308b4
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
d86bf32
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
e864e72
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
c70a482
hkirsman added a commit that referenced this issue Feb 23, 2024
@hkirsman
#7 Add script to update grumphp.yml to add DDEV support.
b628dfc
hkirsman added a commit that referenced this issue Feb 26, 2024
@hkirsman
Merge pull request #8 from wunderio/feature/7-update-grumphp-git-hook…
e6c9e06 
…-from-lando-to-ddev-aware

#7 Add script to update grumphp.yml to add DDEV support.
@hkirsman hkirsman closed this as completed Mar 5, 2024
@hkirsman hkirsman mentioned this issue Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkirsman