You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
User Story
As a user, I’d like preconnect and prefetch links not to be removed when Google Font file is excluded from being downloaded
Acceptance Criteria
When the Google Fonts (it's important that it's about Google Fonts, as in the future we might have other fonts hosted locally) are excluded from being downloaded, Google preconnect and prefetch links should not be removed
When other fonts are excluded (theoretically), Google preconnect and prefetch links should not removed
Removing Google preconnect and prefetch links should work without regression when there's no exclusion at all
The text was updated successfully, but these errors were encountered:
We will do a check with the proposed filter here on this line which is from this PR
This will only remove the preconnect if there are no google fonts in the exclusion.
Estimate the effort ✅
[XS]
My only concern is that the filter is regex compatible and will accept either full url or a part for the exclusion which might not be sufficient enough to detect if a font is from google or not.
@wp-media/product What if we have 2 exclusion filters for both google and other fonts?
User Story
As a user, I’d like
preconnect
andprefetch
links not to be removed when Google Font file is excluded from being downloadedAcceptance Criteria
preconnect
andprefetch
links should not be removedother
fonts are excluded (theoretically), Googlepreconnect
andprefetch
links should not removedpreconnect
andprefetch
links should work without regression when there's no exclusion at allThe text was updated successfully, but these errors were encountered: