Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display accurate licence name, not depending on licence account #7096

Open
nicomollet opened this issue Nov 7, 2024 · 2 comments · May be fixed by #7097
Open

Display accurate licence name, not depending on licence account #7096

nicomollet opened this issue Nov 7, 2024 · 2 comments · May be fixed by #7097
Assignees
Milestone

Comments

@nicomollet
Copy link
Contributor

nicomollet commented Nov 7, 2024

Is your feature request related to a problem? Please describe.

Related to service issue: https://github.com/wp-media/wp-rocket.me/issues/4255

The plugin currently hardcodes licence name in the dashboard view.
It considers the licence_account integer to display Single, Plus or Infinite.

A future update will add new fields to the user endpoint to get the actual name of the license, avoiding having to calculate the licence matching the number of websites.
Goal is to make is dynamic.

The PR only changes dashboard view (Your licence) with a fallback:

  • Display the user->licence->name is if exists in the user endpoint
  • Display the regular licence_account matching licence name if user->licence->name is not set

This is supposed to be a quick change to fix our main issue with new type of licences.

Other work is done in parallel to tackle other features that need to be more dynamic like upgrades, renewals, prices.

Describe the solution you'd like
Get the (new) license name value from the user endpoint.
Display it in the dashboard.
Fallback if not defined.

Incoming PR to be submitted by @wp-media/engineering-service-team

FYI @piotrbak

ETA: before Black Friday / Nov. 19th

@nicomollet
Copy link
Contributor Author

How to change a licence from a customer:
Change the (Rocket) Account field to one of the values matching the new licences: 10, 50, 100, 500.

If I change it to 50
Image

It will update licence>name to Multi50.

@Mai-Saad Mai-Saad self-assigned this Nov 14, 2024
@nicomollet
Copy link
Contributor Author

So the QA was done by @Mai-Saad and the service team has already released the new licence properties on production.

It now only depends on Plugin to to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants