Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #7071 Clean CSS & fonts for host fonts locally #7110

Draft
wants to merge 6 commits into
base: feature/host-google-fonts
Choose a base branch
from
Draft

Closes #7071 Clean CSS & fonts for host fonts locally #7110

wants to merge 6 commits into from

Conversation

remyperona
Copy link
Contributor

Description

Fixes #7071
Explain how this code impacts users.

Type of change

Detailed scenario

Explain how to reproduce the issue (for bugs) or how to trigger the new code. You can refer to the GitHub issue or grooming if it is still applicable.

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@remyperona remyperona self-assigned this Nov 14, 2024
@remyperona remyperona added the type: bug Indicates an unexpected problem or unintended behavior label Nov 14, 2024
@remyperona remyperona added this to the 3.18 milestone Nov 14, 2024
@remyperona remyperona changed the base branch from develop to feature/host-google-fonts November 14, 2024 21:06
@remyperona remyperona added type: sub-task Indicates the issue is a sub-task linked to an epics card and removed type: bug Indicates an unexpected problem or unintended behavior labels Nov 14, 2024
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4160df11 ❌ 26.98% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4160df1) Report Missing Report Missing Report Missing
Head commit (56859de) 38190 16720 43.78%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7110) 63 17 26.98%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@codacy-production Codacy Production
Copy link

codacy-production bot commented Nov 14, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3201ce51 ❌ 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3201ce5) Report Missing Report Missing Report Missing
Head commit (ae3309e) 38359 16829 43.87%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7110) 17 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remyperona remyperona

Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Milestone
3.18
Development

Successfully merging this pull request may close these issues.

3.18 - Clearing the data
1 participant
@remyperona