Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18 - Clearing the data #7071

Open
piotrbak opened this issue Oct 27, 2024 · 2 comments · May be fixed by #7110
Open

3.18 - Clearing the data #7071

piotrbak opened this issue Oct 27, 2024 · 2 comments · May be fixed by #7110
Assignees
Labels
effort: [S] 1-2 days of estimated development time type: new feature Indicates the issue is a request for new functionality
Milestone

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Oct 27, 2024

User Story
As a user, I’d like to clear Google fonts data from the folder structure when necessary

Acceptance Criteria

  • The feature will clear both CSS and Fonts stored locally when the rocket_clean_domain is triggered
  • The feature will clear CSS and Fonts only for specific website when multisite is activated
  • The feature will clear Used CSS when activating/deactivating the feature (no matter if Used CSS is enabled or not)
  • The feature will clear Used CSS when activating/deactivating the feature only for specific website when the multisite is activated (no matter if Used CSS is enabled or not)
@piotrbak piotrbak added the type: new feature Indicates the issue is a request for new functionality label Oct 27, 2024
@piotrbak piotrbak added this to the 3.18 milestone Oct 27, 2024
@jeawhanlee
Copy link
Contributor

jeawhanlee commented Nov 11, 2024

Scope a solution ✅

  • Hook a callback to rocket_after_clean_domain
    • Callback
      • Add logic to handle the removal of fonts and css files hosted locally.
  • Hook a callback to this filter
    • Callback
      • Bail out if feature activations status did not change
      • Call delete_used_css_rows method to remove used css rows
  • Add tests.

Estimate the effort ✅

[S]

@jeawhanlee jeawhanlee added the effort: [S] 1-2 days of estimated development time label Nov 11, 2024
@Miraeld
Copy link
Contributor

Miraeld commented Nov 12, 2024

looks ok to me

@remyperona remyperona self-assigned this Nov 12, 2024
@remyperona remyperona linked a pull request Nov 14, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [S] 1-2 days of estimated development time type: new feature Indicates the issue is a request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants