3.18 - New feature and SaaS part

[piotrbak]

User Story
As a user, I’d like to apply the feature to the URLs visited by saas during RUCSS or OCI/LRC

Acceptance Criteria

• When the visits are made by SaaS (RUCSS, OCI/ALR) we need to make sure that the fonts and CSS are downloaded and the paths are rewritten

[Khadreal]

This is dependent on the completion of #7063 and #7068

Scope a solution:

In the frontend subscriber class, we add a filter rocket_performance_hints_buffer and in the call back function we call the rewrite_fonts process.
We should check if feature is set.

if ( ! $this->options->get( 'host_google_fonts', 0 ) ) {
			return $html;
		}
//start font rewrite process

Estimation
[XS]

[Khadreal]

@piotrbak should this visit happen when the feature is not enabled ?

[piotrbak]

@Khadreal This issue is not about making any visits. It's just to ensure that the feature works when making a request from SaaS

[jeawhanlee]

@Khadreal I'm not sure if we are properly covering the AC in the grooming, shouldn't we be using the rocket_performance_hints_buffer for this?

[jeawhanlee]

I don't think we need to check the query param since rocket_performance_hints_buffer will only be triggered if those query params are set.

wp-rocket/inc/Engine/Common/PerformanceHints/Frontend/Subscriber.php

Lines 69 to 97 in 4b9193b

	public function start_performance_hints_buffer() {
	if ( ! isset( $_GET['wpr_imagedimensions'] ) && ! isset( $_GET['wpr_lazyrendercontent'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
	return;
	}
	if ( ! $this->buffer_tests->can_process_any_buffer() ) {
	return;
	}
	ob_start( [ $this, 'performance_hints_buffer' ] );
	}
	/**
	* Update images that have no width/height with real dimensions for the SaaS
	*
	* @param string $buffer Page HTML content.
	*
	* @return string Page HTML content after update.
	*/
	public function performance_hints_buffer( $buffer ) {
	/**
	* Filters the buffer content for performance hints.
	*
	* @since 3.17
	*
	* @param $buffer Page HTML content.
	*/
	return wpm_apply_filters_typed( 'string', 'rocket_performance_hints_buffer', $buffer );
	}

[Khadreal]

Yes, we don't need to, forgot to remove it after the last edit. We only need to check for the feature itself