Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18 - CDN compatibility part #7064

Open
piotrbak opened this issue Oct 27, 2024 · 3 comments
Open

3.18 - CDN compatibility part #7064

piotrbak opened this issue Oct 27, 2024 · 3 comments
Labels
type: new feature Indicates the issue is a request for new functionality
Milestone

Comments

@piotrbak
Copy link
Contributor

User Story
As a user with the CDN option, I want locally stored Google Fonts and CSS files to be loaded from the CDN

Acceptance Criteria

  1. The feature will rewrite paths to the CSS files to the CDN paths
  2. The feature will rewrite paths to the fonts to the CDN paths
  3. The feature will rewrite paths to the fonts to the CDN paths when the CSS method will be set to be internal one with the filter
@piotrbak piotrbak added the type: new feature Indicates the issue is a request for new functionality label Oct 27, 2024
@piotrbak piotrbak added this to the 3.18 milestone Oct 27, 2024
@jeawhanlee
Copy link
Contributor

Scope a solution ✅

The feature will rewrite paths to the CSS files to the CDN paths

  • We are already doing this for local urls, so it will automatically apply. We might need to adjust the priorities on rocket_buffer

The feature will rewrite paths to the fonts to the CDN paths

  • On this line from the draft PR Check if cdn is enabled and rewrite local url to use the cname.

Estimate the effort ✅
[XS]

@Miraeld
Copy link
Contributor

Miraeld commented Nov 12, 2024

Looks good to me.

@remyperona
Copy link
Contributor

A simple solution to handle the CDN rewrite in the CSS path without having to have the CDN class as a dependency is to use a filter on the URL, and add a hook on it in the CDN Subscriber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new feature Indicates the issue is a request for new functionality
Projects
None yet
Development

No branches or pull requests

4 participants