Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grunt from plugin scaffolding #337

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented May 9, 2024

Fixes #140

  • plugin-gruntfile.mustache is removed.
  • plugin-packages.mustache is removed.
  • plugin-composer.mustache is added.
  • vendor/ is added in plugin-gitignore.mustache
  • In composer wp-cli/i18n-command package is added. Script makepot is kept to generate POT file so that user can generate POT file like this command composer run makepot

@ernilambar ernilambar marked this pull request as ready for review May 9, 2024 05:52
@ernilambar ernilambar requested a review from a team as a code owner May 9, 2024 05:52
Co-authored-by: Pascal Birchler <[email protected]>
@ernilambar
Copy link
Member Author

@swissspidy I am not finding button or link to re-run tests for this PR. Any idea? :-)

@swissspidy
Copy link
Member

I think the button disappears after a 90 days or so (when the logs are deleted). So simply make a change (e.g. merge in the main branch or so) to trigger tests again :)

By the way, I just had a look at this again and I think in favor of the addtextdomain task we could install WPCS via Composer. What do you think? Probably for a follow-up PR though, so we can get the config right.

@ernilambar
Copy link
Member Author

You mean like this in ruleset?

<rule ref="WordPress.Utils.I18nTextDomainFixer">
   <properties>
      <property name="old_text_domain" type="array">
         <element value="" />
      </property>
      <property name="new_text_domain" value="plugin-slug" />
   </properties>
</rule>

@swissspidy
Copy link
Member

Yeah, although that requires old_text_domain to be set for some reason, so maybe not great. So let's forget this for now :-) You don't really need it in a newly scaffolded plugin anyway.

I see we actually have templates/.phpcs.xml.dist already, so installing PHPCS via Composer would be good thing for a next PR though.

@swissspidy swissspidy added this to the 2.5.0 milestone Jan 29, 2025
@swissspidy swissspidy merged commit e706981 into wp-cli:main Jan 29, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Partly) remove Grunt tasks
2 participants