Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected test failure in test_strwidth() #156

Open
danielbachhuber opened this issue Nov 6, 2022 · 1 comment
Open

Fix unexpected test failure in test_strwidth() #156

danielbachhuber opened this issue Nov 6, 2022 · 1 comment

Comments

@danielbachhuber
Copy link
Member

In #155, we marked a test skipped 217cb51 because it was unexpectedly failing.

We should track down why it was failing, and restore the test.

Done is:

  • $this->markTestSkipped() is removed from the test.
@schlessera
Copy link
Member

It passed successfully on my local machine, so my current guess would be that it is either related to the environments locale/encoding or to a missing or differently configured PHP extension.
Once we find out which it is, we still need to figure out whether it is something we need to adapt the tests for, or whether the tests currently are indeed detecting an edge case we failed to take into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants