From fedf30956256a969000a9338f71fdc894da1e778 Mon Sep 17 00:00:00 2001 From: Maxwell Dulin Date: Fri, 19 Jul 2024 08:52:23 -0700 Subject: [PATCH] Add in NIT fixes --- node/pkg/governor/governor.go | 1 - node/pkg/governor/governor_prices.go | 2 +- node/pkg/governor/governor_test.go | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/node/pkg/governor/governor.go b/node/pkg/governor/governor.go index 8f09ecec92..c0598d8a8b 100644 --- a/node/pkg/governor/governor.go +++ b/node/pkg/governor/governor.go @@ -203,7 +203,6 @@ func NewChainGovernor( env common.Environment, coinGeckoApiKey string, ) *ChainGovernor { - return &ChainGovernor{ db: db, logger: logger.With(zap.String("component", "cgov")), diff --git a/node/pkg/governor/governor_prices.go b/node/pkg/governor/governor_prices.go index 11bed80a5a..1cd05ca1b3 100644 --- a/node/pkg/governor/governor_prices.go +++ b/node/pkg/governor/governor_prices.go @@ -101,7 +101,7 @@ func createCoinGeckoQuery(ids string, coinGeckoApiKey string) string { params.Add("vs_currencies", "usd") // If modifying this code, ensure that the test 'TestCoinGeckoPriceChecks' passes when adding a pro API key to it. - // Since the code is requires an API key (which we don't want to publish to git), this + // Since the code requires an API key (which we don't want to publish to git), this // part of the test is normally skipped but mods to sensitive places should still be checked query := "" if coinGeckoApiKey == "" { diff --git a/node/pkg/governor/governor_test.go b/node/pkg/governor/governor_test.go index 260c201794..325bb16315 100644 --- a/node/pkg/governor/governor_test.go +++ b/node/pkg/governor/governor_test.go @@ -2817,7 +2817,7 @@ func TestCoinGeckoQueryFormat(t *testing.T) { } // Create and parse the query - queries := createCoinGeckoQueries(ids, 100, "") // Not API key + queries := createCoinGeckoQueries(ids, 100, "") // No API key require.Equal(t, len(queries), 1) query_url, err := url.Parse(queries[0]) require.Equal(t, err, nil)