Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize message field naming #147

Open
barnjamin opened this issue May 15, 2024 · 0 comments
Open

Standardize message field naming #147

barnjamin opened this issue May 15, 2024 · 0 comments

Comments

@barnjamin
Copy link
Contributor

Across the current messages defined here, we refer to the additional payload as redeemerMessage

https://github.com/wormhole-foundation/example-liquidity-layer/blob/main/universal/rs/messages/src/fast_market_order.rs#L16

https://github.com/wormhole-foundation/example-liquidity-layer/blob/main/universal/rs/messages/src/deposit/fill.rs#L10

However, the CCTP deposit refers to it as payload

https://github.com/wormhole-foundation/wormhole-sdk-rs/blob/6a8c0700db65a2e049a01e5767548f59439dbb3f/universal/raw-vaas/src/payloads/cctp/payloads.rs#L144-L146

We should consider standardizing the name of the field containing extra data to just payload to match others

There may be additional fields that would benefit from standardization as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barnjamin