Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes from test study #258

Open
michaelpalumbo opened this issue Oct 14, 2023 · 4 comments
Open

notes from test study #258

michaelpalumbo opened this issue Oct 14, 2023 · 4 comments

Comments

@michaelpalumbo
Copy link
Collaborator

michaelpalumbo commented Oct 14, 2023

also grab notes from iphone notes app

//
high priority!

the following error occurs sometimes, and when it does it causes the whole app to crash. if webrtc can't connect, shouldn't cause a crash, should be handled and attempt to reconnect. we last multiple play sessions to this where players had nice patches going and then it crashed:

E:\GitHub\mischmasch\node_modules\wrtc\lib\index.js:49
  this._send(data);
       ^
DOMException [InvalidStateError]: RTCDataChannel.readyState is not 'open'
    at RTCDataChannel.send (E:\GitHub\mischmasch\node_modules\wrtc\lib\index.js:49:8)
    at E:\GitHub\mischmasch\Components\Patch\Patch.js:524:52
    at Array.forEach (<anonymous>)
    at Patch.updatePeers (E:\GitHub\mischmasch\Components\Patch\Patch.js:513:37)
    at Patch.update (E:\GitHub\mischmasch\Components\Patch\Patch.js:273:14)
    at Object.updateHandStateMachine (E:\GitHub\mischmasch\app.js:624:12)
    at Object.updateStateMachines (E:\GitHub\mischmasch\app.js:474:37)
    at Immediate.animate (E:\GitHub\mischmasch\app.js:2392:5)
    at process.processImmediate (node:internal/timers:476:21)

pc on the right made a large patch, it was sounding awesome, and then when i reconnected the other pc to the internet, it wiped the pc on the right's scene.

//

need to record audio and video output of both PCs. but note that the pc on the right is not as optimized and drops frames and sometimes hangs outright even without OBS running.

//

urgent: error when webrtc connection times out, this causes a crash of the app, when it should just be handled and retry the connection or go offline

//

urgent: scene not syncing when user joins after other player has started patching. only seems to share their state when both starting from a blank scene

//

they both said it was FUN

//

the PC on the right 'pacman' drops its framerate often. (it's louder too, you can hear it chugging up more often).

//

have them both start a little closer to the desks.

//

get a clamp and clamp the cable to the desk so that the plugs at the computer aren't being pulled on

//

can we have the oculus running in the carpet area using an hdmi and usb extension so that both players have larger play area?

//

would be great to have feedback cables working...

//

what is the rate module? is it actually a source? doesn't appear to work that way...

//

rename 'slide' op display name as 'low pass'

//

played in it for nearly 50 minutes straight

//

said they enjoyed being surrounded by so many modules.

@michaelpalumbo
Copy link
Collaborator Author

make the jacks larger so that when patching many-to-one or many-to-many (if a cable is already in a jack and we want to spawn a new one). problem is that an existing cable makes it really hard to select the jack for spawning a new cable, instead the existing cable gets grabbed by mistake

@michaelpalumbo
Copy link
Collaborator Author

rename MIX to MIXER in the display text

@michaelpalumbo
Copy link
Collaborator Author

it would be cool to copy and paste a section of the patch.

@michaelpalumbo
Copy link
Collaborator Author

each issue here moved to issues #260 #261 #262 #263 #264 #265 #266 #267 respectively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant