Allow default options #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahronak47
requested review from
randrescastaneda and
tonyfujs
and removed request for
randrescastaneda
randrescastaneda
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Hi @shahronak47 ,
All of this looks really good. The only thing that I think is missing is to set up those values with the package is loaded. This can be done like we do in pipaux here. I basically followed Hadley advice.
Thanks.
|
@randrescastaneda I have added a commit that initializes all the option values to Do we want to have different values for these |
|
Hi @shahronak47 , I think that NULL works fine for now. Let's see if we need to change them later on. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task on clickup - https://app.clickup.com/t/2wuyxma
Hi @randrescastaneda , I have created this PR to make it possible to set default options. However, I don't know what would be the right place to document this information as this impacts a lot of functions. Let me know your thoughts.