-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manuals: clicking on sidebar item doesn't work in specific cases #688
Comments
This will be fixed with #682 |
@AkshayWarrier I tested your changes with a598cd8 and while now the rows are not collapsed, there are some regressions. Search for something, click on a row, click on link in the page, click on any row - the row is selected, but the page is not opened. Next click works. For example search for portal, click on XdpPortl row, click on GObject link in the page, click on any row: I also got the feeling that clicking on a row in the search sidebar got slower. |
Thanks for testing, but this happens because when you click on the "GObject" link, it's not actually loading the local documentation but it's opening an HTTP link to load it into the webview (which is also the reason why it takes longer to load it). This is true for all links that reference other docsets outside of its own one. If you click on the link for example I plan to change this in a future PR so that it redirects HTTP uris that refer other documentation to the local documentation if it has one. It's also one of the tasks listed on #640 So it's not really a regression but just a missing feature that hasn't been implemented yet. |
Steps to reproduce:
Expected result:
Observed result:
This can be reproduced with any page.
The text was updated successfully, but these errors were encountered: