Skip to content
This repository has been archived by the owner on Jan 1, 2025. It is now read-only.

Structural ideas #5

Open
yakuter opened this issue Sep 11, 2021 · 0 comments
Open

Structural ideas #5

yakuter opened this issue Sep 11, 2021 · 0 comments

Comments

@yakuter
Copy link
Contributor

yakuter commented Sep 11, 2021

Thanks for this great package. This works fine but I think needs a structural change.

There are 2 different jobs in one package; consumer and producer. So I think they should be in sub packages like consumer and producer package.

Also I see that you call sarama config inside new consumer/producer functions. This call should be out of the box and set with parameter to new functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant