Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better package resource discovery #113

Open
tachyontraveler opened this issue Dec 18, 2020 · 0 comments
Open

Better package resource discovery #113

tachyontraveler opened this issue Dec 18, 2020 · 0 comments

Comments

@tachyontraveler
Copy link
Member

tachyontraveler commented Dec 18, 2020

file discovery using os.path.dirname(__file__) is prone to several issues. One of them is the possibility of encountering errors when the package is installed as an egg. Another set of errors can occur when qmpy is installed on OSs other than Linux.

To fix these issues, we'd need to change the file discovery method from os.path to pkg_resources.resource_filename or similar dedicated package file discovery options

Another work is to be done on adding a pre-commit system to reformat qmpy scripts - possible using the package black

Thanks to @hegdevinayi for the ideas

@hegdevinayi hegdevinayi changed the title Pre-commit reformatting and Better method to package discovery and file access Better package resource discovery Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant