Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dismissal of Sliver Modal Sheet on Downward Drag at Scroll Edge #331

Open
sheeroo opened this issue Sep 24, 2024 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@sheeroo
Copy link

sheeroo commented Sep 24, 2024

when using a sliver modal sheet with scrollable content like a list, dismissing the modal by dragging it down isn't possible once the scrollable content has reached its top edge (meaning it can't scroll up any further).

This behavior differs from common interaction patterns in other apps, where a downward drag at the top of a scrollable list dismisses the modal.

Adding this feature would enhance the modal's usability by allowing it to be dismissed with a downward swipe when the scroll position is at the top edge.

@sheeroo sheeroo added the enhancement New feature or request label Sep 24, 2024
@ulusoyca
Copy link
Collaborator

Hi @sheeroo Are you using the latest version? We added this feature: #283

@ulusoyca ulusoyca self-assigned this Sep 25, 2024
@sheeroo
Copy link
Author

sheeroo commented Sep 25, 2024

Hi @sheeroo Are you using the latest version? We added this feature: #283

Hiii, thanks for the quick reply and the amazing work. You are right I was using an older version, sorry for that. I tried this implementation but I was a little disappointed with the result. The drag animation does't follow the finger quite well while dragging down. I think the user experience is quite off. The package smooth_sheets does a really good job with the drag animation if that provides any help. Again thanks for all the work you have put into this :)

@ulusoyca
Copy link
Collaborator

@sheeroo Thanks for the input. Would you like to make a contribution? I can support you if you consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants