Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WoltModalSheet does not follow finger movement smoothly when dismissing #269

Open
LiangLuDev opened this issue Jul 22, 2024 · 4 comments
Open
Labels
bug Something isn't working in triage

Comments

@LiangLuDev
Copy link

When using WoltModalSheet.show, the modal does not follow the finger movement smoothly when attempting to close it by pulling down (similar to ModalBottomSheet). Instead, it requires significant force to pull down and close. I couldn’t find a setting to modify this behavior and am unsure if it can be adjusted.

Additionally, the distance from the top of the modal to the status bar cannot be modified. I have set the forceMaxHeight property, but it does not change the distance.

Could you please provide guidance on how to resolve these issues?

Reproduction Steps:

1.	Use WoltModalSheet.show to display a modal.
2.	Attempt to close the modal by pulling it down with a finger.
3.	Observe the resistance to movement and the inability to smoothly follow the finger.

Expected Behavior:

The modal should smoothly follow the finger movement when pulling down to close, similar to the behavior of ModalBottomSheet. Additionally, the distance from the top of the modal to the status bar should be adjustable.

Actual Behavior:

The modal requires significant force to pull down and close, and the distance to the status bar cannot be modified even when setting the forceMaxHeight property.

Environment:

•	Library version: 0.7.1
•	Platform: Mobile
•	Flutter version: 3.19

Thank you for your assistance!

@LiangLuDev LiangLuDev added bug Something isn't working in triage labels Jul 22, 2024
@ulusoyca
Copy link
Collaborator

Hello @LiangLuDev Can you check the Custom Modal Type section in ReadMe, and create a custom modal type with a custom minFlingVelocity ?
https://pub.dev/packages/wolt_modal_sheet#defining-custom-modal-types

@LiangLuDev
Copy link
Author

Hello @LiangLuDev Can you check the Custom Modal Type section in ReadMe, and create a custom modal type with a custom minFlingVelocity ?

Yes, I found this parameter and tried to set this property. Unfortunately, it did not take effect. I also tried it in the test demo you provided, but it did not work either.

@ulusoyca
Copy link
Collaborator

Yikes! Thanks for reporting. I will take this. Maybe @durannumit can also take a look?

@durannumit
Copy link
Collaborator

Yikes! Thanks for reporting. I will take this. Maybe @durannumit can also take a look?

sure I will check according to comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in triage
Projects
None yet
Development

No branches or pull requests

3 participants