Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency / build-order solver does not consider runtime deps . #1217

Open
smoser opened this issue Sep 30, 2024 · 1 comment
Open

Dependency / build-order solver does not consider runtime deps . #1217

smoser opened this issue Sep 30, 2024 · 1 comment
Labels
bug Something isn't working needs-triage applied to all new customer/user issues. Removed after triage occurs.

Comments

@smoser
Copy link
Contributor

smoser commented Sep 30, 2024

I noticed this when putting up a PR to wolfi that changed lots of packages.

It appeared to me that the solver did not consider runtime dependencies, but c-i was doing test immediately after build.
So for a package P that depended on A for build and A and C for runtime, there was no guarantee that C would be built before P.

It is possible that this is acceptable, and the build/test should simply be changed to do "build all the things and then test all the things". I don't have a good argument against that, but the current process in github actions was 'make package/' and then 'make test/'.

@smoser smoser added bug Something isn't working needs-triage applied to all new customer/user issues. Removed after triage occurs. labels Sep 30, 2024
@xnox
Copy link
Contributor

xnox commented Oct 5, 2024

In elastic builds I believe all builds are done first, then tests.

We could adopt same for GHA builds too. Not sure how much work that would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage applied to all new customer/user issues. Removed after triage occurs.
Projects
None yet
Development

No branches or pull requests

2 participants