Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move csv2bufr templates to separate repo #546

Closed
tomkralidis opened this issue Oct 7, 2023 · 8 comments
Closed

move csv2bufr templates to separate repo #546

tomkralidis opened this issue Oct 7, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tomkralidis
Copy link
Collaborator

Putting csv2bfur templates outside csv2bufr proper will alleviate the need to versions/publishing. As discussed, we should move csv2bufr templates back to https://github.com/wmo-im/csv2bufr-templates and have wis2box ref that setup again.

@david-i-berry
Copy link
Member

Related PR in csv2bufr repo: wmo-im/csv2bufr#125

@david-i-berry
Copy link
Member

david-i-berry commented Jan 17, 2024

To do:

  • Update csv2bufr docs on installation of csv2bufr templates
  • Integration testing with wis2box stack

@tomkralidis
Copy link
Collaborator Author

2024-01-30

  • docs/testing for next week

@david-i-berry
Copy link
Member

david-i-berry commented Feb 5, 2024

Changes tested with wis2box-api branch (https://github.com/wmo-im/wis2box-api/tree/wis2box-1.0b7).

Docs updated for csv2bufr.

WIS2box docs need updating (https://docs.wis2box.wis.wmo.int/en/1.0b6/reference/running/data-pipeline-plugins.html#wis2box-data-csv2bufr-observationdatacsv2bufr):

(@maaikelimper for info)

Add subsection on environment variables:

csv2bufr uses three environment variables, two to specify the originating centre and sub-centres for the BUFR message and one to specify the search path for the csv2bufr templates:

BUFR_ORIGINATING_CENTRE=65535 # defaults missing value
BUFR_ORIGINATING_SUBCENTRE=65535 # default missing value
CSV2BUFR_TEMPLATES=/custom/path/to/templates # ./ and /opt/csv2bufr/templates searched by default

Sample cs2vbufr templates can be downloaded from https://github.com/wmo-im/csv2bufr-templates and installed in /opt/csv2bufr/templates for use with csv2bufr, e.g.

mkdir /opt/csv2bufr # only required if directory does not exist
cd /opt/csv2bufr
wget https://github.com/wmo-im/csv2bufr-templates/archive/refs/tags/v0.1.tar.gz # download release v0.1 of templates
tar -zxf v0.1.tar.gz --strip-components=1 csv2bufr-templates-0.1/templates # extract the templates into the search path

@david-i-berry
Copy link
Member

Linked to #536

@tomkralidis
Copy link
Collaborator Author

tomkralidis commented Feb 6, 2024

2024-02-06:

@tomkralidis
Copy link
Collaborator Author

2024-02-13:
@david-i-berry

  • template ids are uuids
  • use human readable strings back in data mappings
  • update filenames for clarity

@maaikelimper

  • API: add template lookup to API for UI workflow

@tomkralidis
Copy link
Collaborator Author

2024-03-05:

  • fixed in API, will be fixed once API updates are merged/integrated to stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants