-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .Net 8 preview 3 unified artifacts #7401
Comments
Will this be fixed in 6.x? |
While, I am very interested in implementing this feature, no customers have expressed interest in it. Other issues with higher priority remain to be resolved in WiX v6. That is why this issue is in the |
As the original author of this thread, I am still interested... |
We are interested as well |
I am also interested. I have manually added support to my project with these lines: <PropertyGroup>
<!-- WiX SDK doesn't follow UseArtifactsOutput, apply it manually -->
<ConfigurationLower>$(Configuration.ToLowerInvariant())</ConfigurationLower>
<PlatformLower>$(Platform.ToLowerInvariant())</PlatformLower>
<ConfigurationWithPlatform>$(ConfigurationLower)_$(PlatformLower)</ConfigurationWithPlatform>
<OutputPath>$([MSBuild]::NormalizeDirectory($(ArtifactsPath), 'bin\$(MSBuildProjectName)', $(ConfigurationWithPlatform)))</OutputPath>
<IntermediateOutputPath>$([MSBuild]::NormalizeDirectory($(ArtifactsPath), 'obj\$(MSBuildProjectName)', $(ConfigurationWithPlatform)))</IntermediateOutputPath>
</PropertyGroup> However, this isn't a complete solution. For starters, I believe it only works with an explicit I recognize that it may be too late for WiX 6, but I am willing to implement this myself and give a PR for WiX 7, if the team is interested. |
@brantburnett you're welcome to dig into it. Integrating this support into the wix.targets is something that I'll need to understand deeply, so be aware I'll go through the development myself and may not use provided PRs. But that isn't to say that they wouldn't be helpful. :) |
Bugs
WiX 4.0
4.0.0+8c757c0f
Visual Studio 2022 v17.6.0 Preview 3
Heatwave 1.0.1
.Net 8.0.0-preview.3.23174.8
.Net 8 preview 3 introduced a unified project artifact directory enabled by specifying
in Directory.Build.props
Building an installer with this property enabled with WiX 4 results in a package generated in the directory of the wixproj project file while all other projects respect the new option.
This is not terrible, but I'd request that WiX 5 follows the unified output convention introduced in the .Net 8 SDK
The text was updated successfully, but these errors were encountered: