Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add code snippet and blurb about experimentalDisableStreaming option #10761

Merged
merged 6 commits into from
Jan 27, 2025
Merged

docs: add code snippet and blurb about experimentalDisableStreaming option #10761

merged 6 commits into from
Jan 27, 2025

Conversation

artmsilva
Copy link
Contributor

Description (required)

Related issues & labels (optional)

@artmsilva artmsilva mentioned this pull request Jan 23, 2025
Merged
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 23, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/react.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aafc0b6
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6797e24e5241bc0008f99b74
😎 Deploy Preview https://deploy-preview-10761--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sarah11918
sarah11918 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for providing this, and welcome to Team Docs! 🥳 I'll do a final check for polish with the other minor release docs when the feature is set to be released.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jan 24, 2025
@ascorbic
Copy link
Contributor

@sarah11918 this is just a minor for the React integration, so I don't think we'll wait for an Astro minor

@sarah11918 sarah11918 added Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! and removed minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jan 24, 2025
@sarah11918 sarah11918 merged commit 9fa190f into withastro:main Jan 27, 2025
9 of 10 checks passed
@jsparkdev jsparkdev mentioned this pull request Jan 28, 2025
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 28, 2025
@ArmandPhilippot
i18n(fr): update integrations-guide/react.mdx
b643f18 
See withastro#10761
@ArmandPhilippot ArmandPhilippot mentioned this pull request Jan 28, 2025
Merged
ArmandPhilippot added a commit that referenced this pull request Jan 28, 2025
@ArmandPhilippot
i18n(fr): update integrations-guide/react.mdx (#10821)
20fb146 
See #10761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artmsilva @astrobot-houston @ascorbic @sarah11918