Add Status Bar Icon with Shortcuts to Start/Stop the Server. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
This PR is an experiment to add the status bar icon on the right side of the top macOS bar.
We have tried two different approaches:
SwiftUIView inside the status item to recreate the menu. This solution has the advantage to use theappEnvironmentand fetch the current state of the server to enable/disable Start and Stop server interactions when not available. This solution shows some bug when clicking the buttons when the app is in background.AppKitway of creating items inside the menu and linking an interaction for each item. This solution does not present the aforementioned bug, but theappEnvironmentcannot be used.