Add Editor Syntax Highlighting #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 13, 2021 17:47
# Conflicts: # Sources/App/Views/Common/Editor.swift # Sources/App/Views/Sections/Editor/Detail/EditorDetail.swift # project.yml
gaetanomatonti
changed the title
…hub.com/wise-emotions/mocka into experimental/editor-syntax-highlighting # Conflicts: # Sources/App/Views/Common/MockaSourceCodeEditor.swift
gaetanomatonti
requested review from
TheInkedEngineer,
FabrizioBrancati,
MicheleMola,
davideruisi,
davix93,
gianfilippocisternino and
martin-e91
FabrizioBrancati
suggested changes
Aug 27, 2021
Sources/App/Resources/Assets.xcassets/Keyword.colorset/Contents.json
Outdated
Show resolved
Hide resolved
Sources/App/Resources/Assets.xcassets/Number.colorset/Contents.json
Outdated
Show resolved
Hide resolved
Sources/App/Resources/Assets.xcassets/String.colorset/Contents.json
Outdated
Show resolved
Hide resolved
| .frame(maxWidth: .infinity, alignment: .leading) | ||
| .font(.headline) | ||
| .foregroundColor(Color.latte) | ||
| VStack(spacing: 16) { |
There was a problem hiding this comment.
Why 16? Does this component look different from the previous one?
There was a problem hiding this comment.
previously it was 10, I just raised it to be a multiple of 4.
| import SwiftUI | ||
|
|
||
| /// A source code editor with custom theme. | ||
| struct MockaSourceCodeTextEditor: NSViewRepresentable { |
There was a problem hiding this comment.
Suggested change
| struct MockaSourceCodeTextEditor: NSViewRepresentable { | |
| struct SourceCodeTextEditor: NSViewRepresentable { |
There was a problem hiding this comment.
SourceCodeTextEditor is the name of the View component provided by Sourceful
Comment on lines
+24
to
+26
| fieldsSection | ||
|
|
||
| headersSection |
There was a problem hiding this comment.
Why did you create these vars?
There was a problem hiding this comment.
to clean up the body a little bit, I found it a bit hard to read. we can remove them if you prefer
| @@ -21,6 +21,10 @@ packages: | |||
| Vapor: | |||
| url: https://github.com/vapor/vapor | |||
| from: 4.0.0 | |||
| Sourceful: | |||
| url: https://github.com/twostraws/Sourceful | |||
| branch: main | |||
There was a problem hiding this comment.
There are no releases available?
There was a problem hiding this comment.
releases are way behind main
gaetanomatonti
requested review from
FabrizioBrancati
and removed request for
TheInkedEngineer
gaetanomatonti
removed request for
davideruisi,
martin-e91 and
FabrizioBrancati
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds syntax highlighting to the JSON editor.
Type of Change
Checklist:
Screenshots