feat: Ask User for call quality feedback [WPB-9452] #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
👕 size: XL
type: feature ✨
labels
|
| Report | Mon, August 26, 2024 at 10:20:49 UTC |
| Project | kalium |
| Branch | feat/ask_user_for_call_quality_feedback |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | ➖ (view plot) | 688,508.08 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | ➖ (view plot) | 340,722,453.56 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | ➖ (view plot) | 923,739,351.26 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | ➖ (view plot) | 21,428,007.07 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Datadog ReportBranch report: ✅ 0 Failed, 3067 Passed, 105 Skipped, 10.36s Total Time |
borichellow
requested review from
ohassine,
vitorhugods,
yamilmedina,
alexandreferris and
MohamadJaara
alexandreferris
approved these changes
Aug 23, 2024
| override suspend fun invoke(): Boolean = | ||
| userConfigRepository.getNextTimeForCallFeedback().map { | ||
| it > 0L && DateTimeUtil.currentInstant() > Instant.fromEpochMilliseconds(it) | ||
| }.getOrElse(true) |
There was a problem hiding this comment.
the .getOrElse(true) will mean that the first call of a fresh logged in user will display the feedback right?
Comment on lines
+47
to
+49
| sealed class EndCallResult { | ||
| data object VerificationDegraded : EndCallResult() | ||
| data class AskForFeedback(val shouldAsk: Boolean) : EndCallResult() |
yamilmedina
approved these changes
Aug 23, 2024
| @@ -46,6 +47,8 @@ interface EndCallUseCase { | |||
| internal class EndCallUseCaseImpl( | |||
| private val callManager: Lazy<CallManager>, | |||
| private val callRepository: CallRepository, | |||
| private val endCallListener: EndCallResultListener, | |||
| private val shouldAskCallFeedbackUseCase: ShouldAskCallFeedbackUseCase, | |||
There was a problem hiding this comment.
Suggested change
| private val shouldAskCallFeedbackUseCase: ShouldAskCallFeedbackUseCase, | |
| private val shouldAskCallFeedback: ShouldAskCallFeedbackUseCase, |
|
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
MohamadJaara
pushed a commit
that referenced
this pull request
Oct 18, 2024
* feat: Ask User for Call quality feedback * Code-style fix * Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
Every at least 3 days, when user ended a call we want to ask Call Quality feedback.
Causes (Optional)
There is a task saying so.
Solutions
Implement it, by adding
ShouldAskCallFeedbackUseCasewhich will be called on every call ending and if user should asked for feedback kalium will call updatedEndCallResultListenerAnd new
ObserveAskCallFeedbackUseCasewhich observes flowEndCallResultListenerfor corresponding result when user should or should not be asked for feedback.Not related changes:
while updating tests I noticed that we have 2
CallRepositoryArrangement, one inarrangement.repositoryone inarrangementpackage. So i merge them into one.