-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use \v
by default in :Acks
invocations triggered by the <Plug>(FerretAcks)
mapping
#61
Comments
You need a trailing slash. ie. Surprised it didn't show an error. |
Depending on your |
hey @wincent big fan here! Thanks for checking, but yeah, I just forgot to add a slash on the comment, but when I tried it it won't work. |
@wincent I've added an asciinema recording: |
sorry @wincent I didn't see your comment about magic setting So my Acks should be like this? (need to add \v) ?
Also I was wondering, if Acks is using :cfdo under the hood, isn't I guess this is where we set that? |
Personally, I think "very magic" makes the most sense (Vim's idiosyncratic regular expressions drive me up the wall), but I am reluctant to It's true that we could make the mapping prepend it by default, but I would probably want it to have an option for it. |
I'm pro for making I wish vim plugins have semver, that way you can iterate over major versions and won't need to worry about breaking other people's workflow. However, using But I do respect your reluctance. Perhaps some compromise of having a gated option as well? So that people can opt-in for the very magic? (If making it a default is a non option). We could also have a gate where users can use legacy bindings too? |
I think it's probably ok to change the default even though people tend not to pay attention to semver, for a couple reasons:
|
I pushed a draft implementation of this to the "next" branch. I'll test it for a while there and if all looks good will merge that into "master". |
\v
by default in :Acks
invocations triggered by the <Plug>(FerretAcks)
mapping
sweet thanks for the update @wincent! |
If I try to do
:Ack foo|bar
then
:Acks /foo|bar/baz/
It doesn't update anything?
The text was updated successfully, but these errors were encountered: