added emptyepsilon #1301
Open
added emptyepsilon #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. If you're concerned about effeciency, it could also be done with a single sed command. |
| get_github_releases "daid/EmptyEpsilon" "latest" | ||
| if [ "${ACTION}" != prettylist ]; then | ||
| URL="$(grep -m 1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4)" | ||
| VERSION_PUBLISHED="$(cut -d'-' -f2 <<< "${URL}" | cut -d'/' -f1)" |
There was a problem hiding this comment.
This is OK. However there may be an issue with how they handle their versioning:
Currently this ends up with
Installed: 2024.12.8
Published: 2024.12.08
which is actually probably OK as .09 will be seen as "higher" than .8, but the inconsistency is a little worrying...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EmptyEpsilon
Fixes #1300
Please take a close look at how the VERSION_PUBLISHED variable is calculated (line 6 of the emptyepsilon file). I'm unsure if this is the best or most clear way to do it.