Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollback for non-raw terminals #8

Open
willothy opened this issue Oct 28, 2023 · 0 comments
Open

Scrollback for non-raw terminals #8

willothy opened this issue Oct 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@willothy
Copy link
Owner

willothy commented Oct 28, 2023

Can check if terminal is raw via the termios crate. All terminals can have scrollback buffers since dynamically checking if a terminal needs one would be complicated, but scroll events should be sent directly to terminals in raw mode instead of affecting the screen's view.

TODO:

  • Necessary changes:
    • Restructure process output handling to allow buffering before passthrough over RPC to client.
    • Refactor input handling to allow for more complex keymaps (refactor!: rework input handling #7)
      • Migrate fully from Termion to Termwiz?
  • Scrollback implementation
    • Add per-session scrollback buffer with bounded capacity (~1000 lines?)
    • Create basic "view" model to control the view over the scrollback buffer
@willothy willothy added the enhancement New feature or request label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant