Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Firefox on Mac OS X #52

Closed
dmongeau opened this issue Jan 15, 2015 · 3 comments · May be fixed by #51
Closed

Bug in Firefox on Mac OS X #52

dmongeau opened this issue Jan 15, 2015 · 3 comments · May be fixed by #51

Comments

@dmongeau
Copy link

There is a bug with the line 210 at least in Firefox using a trackpad from a Macbook pro:

wheelSpeedDelta = -(evntObj.deltaY || evntObj.detail || (-1 / 3 * evntObj.wheelDelta)) / 40

When evntObj.deltaY is equals to 0, it goes to evntObj.detail which is also equals to 0, which goes to (-1 / 3 * evntObj.wheelDelta) returning a NaN.

Also only the deltaY is used even if the axis is set to x.

Here is a pull request that correct this issue:
#51

@dmongeau
Copy link
Author

dmongeau commented Feb 9, 2015

Any updates on this?

@zrain
Copy link

zrain commented Oct 19, 2015

if( isNaN(wheelDelta) ){
wheelDelta = -(evntObj.deltaY / 40);
}

@charlenelu
Copy link

Thanks for @zrain, i`ve fixed using the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants