Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Workspace kwarg ignore_missing_files to load_missing_file_data #230

Open
whitews opened this issue Nov 14, 2024 Discussed in #229 · 0 comments
Open

Rename Workspace kwarg ignore_missing_files to load_missing_file_data #230

whitews opened this issue Nov 14, 2024 Discussed in #229 · 0 comments

Comments

@whitews
Copy link
Owner

whitews commented Nov 14, 2024

Discussed in #229

Originally posted by ksebby November 13, 2024
I suggest changing the Workspace ignore_missing_files parameter to load_missing_file_data or something similar.

Currently:
ignore_missing_files = False (the default) does in fact ignore the missing samples--the gate data and sample ids are not loaded. Although there is a warning message.

ignore_missing_files = True does not ignore the missing files and loads the gate data and sample ids of missing FCS files.

I expected the opposite behavior from the name. This one tripped me up for a while...

@whitews whitews changed the title Rename Workspace kwarg ignore_missing_files to load_missing_file_data Rename Workspace kwarg ignore_missing_files to load_missing_file_data Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant