Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Scope churn calculation to provided paths #420

Open
Fito opened this issue Nov 23, 2022 · 1 comment
Open

Proposal: Scope churn calculation to provided paths #420

Fito opened this issue Nov 23, 2022 · 1 comment

Comments

@Fito
Copy link
Contributor

Fito commented Nov 23, 2022

Running rubycritic on large repositories with many years of commits can take > 30 minutes. I traced this down to the churn calculation. It is currently hard-coded to run git log on . which can be very expensive depending on the codebase.
For example, in mono-repositories with multiple projects and/or with multiple languages/frameworks it makes more sense to target RubyCritic's analysis to specific directories.

I added more information in this PR: #419

Thank you!
@fbuys
Copy link
Collaborator

fbuys commented Jun 15, 2023

I believe this issue is addressed in this PR: #419

Can we close this issue @Fito?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fito @fbuys