Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short hidden track 0 not written to disk #620

Open
milkcanworld opened this issue May 3, 2024 · 4 comments
Open

Short hidden track 0 not written to disk #620

milkcanworld opened this issue May 3, 2024 · 4 comments

Comments

@milkcanworld
Copy link

milkcanworld commented May 3, 2024

When attempting to rip the 1st pressing of Doggystyle, whipper claims to find hidden track 0 audio and acts like it's ripping it to a flac, but that flac is not present in the folder post-rip.

Is this due to 31 frames being less than 2 seconds, i.e. the Red Book minimum track time? If so, I wonder if there should be an exception for hidden tracks or something like that, as it's already not exactly a track in the traditional sense.

INFO:whipper.command.cd:using configured read offset 6
INFO:whipper.command.cd:checking device /dev/sr0
WARNING:whipper.program.utils:command 'eject -t /dev/sr0' returned with exit code '1' (b'eject: CD-ROM tray close command failed: No such file or directory')
CDDB disc id: 040ce013
MusicBrainz disc id nVeJRIj9Z.9szgUKM6Da9cRiE_k-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+19+247412+182+8512+19360+35222+37975+56272+59052+78892+95205+111437+129927+151117+169540+172230+195110+198442+215802+220020+230622&tracks=19&id=nVeJRIj9Z.9szgUKM6Da9cRiE_k-
Disc duration: 00:54:56.400, 19 audio tracks

Matching releases:

Artist  : Snoop Doggy Dogg
Title   : Doggystyle (1st pressing)
Duration: 00:54:49.942
URL     : https://musicbrainz.org/release/7e422cee-608c-4f5a-9740-729f012e121b
Release : 7e422cee-608c-4f5a-9740-729f012e121b
Type    : Album
Barcode : 765449227929
Country : United States
Cat no  : 7 92279-2

Track 1 finished, found 36 Q sub-channels with CRC errors
Track 2 finished, found 8 Q sub-channels with CRC errors
Track 3 finished, found 18 Q sub-channels with CRC errors
Track 4 finished, found 27 Q sub-channels with CRC errors
Track 5 finished, found 30 Q sub-channels with CRC errors
Track 6 finished, found 1 Q sub-channels with CRC errors
Track 7 finished, found 22 Q sub-channels with CRC errors
Track 8 finished, found 7 Q sub-channels with CRC errors
Track 9 finished, found 3 Q sub-channels with CRC errors
Track 10 finished, found 13 Q sub-channels with CRC errors
Track 11 finished, found 12 Q sub-channels with CRC errors
Track 12 finished, found 7 Q sub-channels with CRC errors
Track 13 finished, found 1 Q sub-channels with CRC errors
Track 14 finished, found 10 Q sub-channels with CRC errors
Track 16 finished, found 6 Q sub-channels with CRC errors
Track 17 finished, found 8 Q sub-channels with CRC errors
Track 18 finished, found 3 Q sub-channels with CRC errors
Track 19 finished, found 11 Q sub-channels with CRC errors
INFO:whipper.program.cdrdao:creating output directory /home/vivian/.local/whipper/sym/album/Snoop Doggy Dogg - Doggystyle (1st pressing)
INFO:whipper.command.cd:found Hidden Track One Audio from frame 0 to 31
INFO:whipper.command.cd:ripping track 0 of 19: 00. Snoop Doggy Dogg - Hidden Track One Audio.flac
INFO:whipper.program.cdparanoia:checksums match, 16694661
INFO:whipper.command.cd:CRCs match for track 0
Peak level: 0.000000
Rip quality: 100.00%
INFO:whipper.command.cd:HTOA discarded, contains digital silence
INFO:whipper.command.cd:ripping track 1 of 19: 01. Snoop Doggy Dogg - Bathtub.flac
INFO:whipper.program.cdparanoia:checksums match, 3d97de53
INFO:whipper.command.cd:CRCs match for track 1
Peak level: 0.976868
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 2 of 19: 02. Snoop Doggy Dogg - G Funk Intro.flac
INFO:whipper.program.cdparanoia:checksums match, 81d8fb13
INFO:whipper.command.cd:CRCs match for track 2
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 3 of 19: 03. Snoop Doggy Dogg - Gin and Juice.flac
INFO:whipper.program.cdparanoia:checksums match, 69ed218e
INFO:whipper.command.cd:CRCs match for track 3
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 4 of 19: 04. Snoop Doggy Dogg featuring The Queen of Funk and Ricky Harris - W Balls.flac
INFO:whipper.program.cdparanoia:checksums match, 5c336049
INFO:whipper.command.cd:CRCs match for track 4
Peak level: 0.978027
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 5 of 19: 05. Snoop Doggy Dogg - Tha Shiznit.flac
INFO:whipper.program.cdparanoia:checksums match, b317a794
INFO:whipper.command.cd:CRCs match for track 5
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 6 of 19: 06. Snoop Doggy Dogg - Domino Intro.flac
INFO:whipper.program.cdparanoia:checksums match, beeca7ed
INFO:whipper.command.cd:CRCs match for track 6
Peak level: 0.985046
Rip quality: 99.66%
INFO:whipper.command.cd:ripping track 7 of 19: 07. Snoop Doggy Dogg - Lodi Dodi.flac
INFO:whipper.program.cdparanoia:checksums match, 41635af1
INFO:whipper.command.cd:CRCs match for track 7
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 8 of 19: 08. Snoop Doggy Dogg featuring Dat Nigga Daz - Murder Was the Case (DeathAfterVisualizingEternity).flac
INFO:whipper.program.cdparanoia:checksums match, b16f427e
INFO:whipper.command.cd:CRCs match for track 8
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 9 of 19: 09. Snoop Doggy Dogg featuring D.O.C., RBX and Tha Dogg Pound - Serial Killa.flac
INFO:whipper.program.cdparanoia:checksums match, b2e0ee5f
INFO:whipper.command.cd:CRCs match for track 9
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 10 of 19: 10. Snoop Doggy Dogg - Who Am I (What’s My Name)?.flac
INFO:whipper.program.cdparanoia:checksums match, 31b8938c
INFO:whipper.command.cd:CRCs match for track 10
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 11 of 19: 11. Tha Dogg Pound featuring The Lady of Rage - For All My Niggaz & Bitches.flac
INFO:whipper.program.cdparanoia:checksums match, 4d6f3a2a
INFO:whipper.command.cd:CRCs match for track 11
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 12 of 19: 12. Snoop Doggy Dogg featuring Nate Dogg, Warren G and Kurupt - Ain’t No Fun (If the Homies Can’t Have None).flac
INFO:whipper.program.cdparanoia:checksums match, 1d196875
INFO:whipper.command.cd:CRCs match for track 12
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 13 of 19: 13. Snoop Doggy Dogg - Chronic Relief Intro.flac
INFO:whipper.program.cdparanoia:checksums match, 59a36fb5
INFO:whipper.command.cd:CRCs match for track 13
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 14 of 19: 14. Snoop Doggy Dogg featuring Tha Dogg Pound and The Dramatics - Doggy Dogg World.flac
INFO:whipper.program.cdparanoia:checksums match, 308ef0fb
INFO:whipper.command.cd:CRCs match for track 14
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 15 of 19: 15. Snoop Doggy Dogg - Class Room Intro.flac
INFO:whipper.program.cdparanoia:checksums match, 3fc654c4
INFO:whipper.command.cd:CRCs match for track 15
Peak level: 0.985168
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 16 of 19: 16. Snoop Doggy Dogg - Gz and Hustlas.flac
INFO:whipper.program.cdparanoia:checksums match, 4d964168
INFO:whipper.command.cd:CRCs match for track 16
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 17 of 19: 17. Snoop Doggy Dogg - Checkin’.flac
INFO:whipper.program.cdparanoia:checksums match, 31cc8d01
INFO:whipper.command.cd:CRCs match for track 17
Peak level: 0.984436
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 18 of 19: 18. Snoop Doggy Dogg - Gz Up, Hoes Down.flac
INFO:whipper.program.cdparanoia:checksums match, ff2ae62a
INFO:whipper.command.cd:CRCs match for track 18
Peak level: 0.999969
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 19 of 19: 19. Snoop Doggy Dogg featuring Lil Malik, aka Lil Hershey Loc - Pump Pump.flac
INFO:whipper.program.cdparanoia:checksums match, 67e2ae52
INFO:whipper.command.cd:CRCs match for track 19
Peak level: 1.000000
Rip quality: 100.00%
INFO:whipper.image.cue:parsing .cue file '/home/vivian/.local/whipper/sym/album/Snoop Doggy Dogg - Doggystyle (1st pressing)/Snoop Doggy Dogg - Doggystyle (1st pressing).cue'
INFO:whipper.common.program:2 AccurateRip response(s) found
track  0: unknown          (not tracked)
track  1: rip accurate     (max confidence    109) v1 [2aa65ad7], v2 [07236b1a], DB [2aa65ad7, 07236b1a]
track  2: rip accurate     (max confidence    111) v1 [430aa06d], v2 [55c4091c], DB [430aa06d, 55c4091c]
track  3: rip accurate     (max confidence    108) v1 [b924b54e], v2 [413d6166], DB [b924b54e, 413d6166]
track  4: rip accurate     (max confidence    110) v1 [a2640f31], v2 [d0a26b06], DB [a2640f31, d0a26b06]
track  5: rip accurate     (max confidence    112) v1 [8b19251b], v2 [39e7aa87], DB [8b19251b, 39e7aa87]
track  6: rip accurate     (max confidence    111) v1 [0fd2144e], v2 [95eae754], DB [0fd2144e, 95eae754]
track  7: rip accurate     (max confidence    109) v1 [0c3b6090], v2 [22f026a7], DB [0c3b6090, 22f026a7]
track  8: rip accurate     (max confidence    112) v1 [d3837da0], v2 [dd574421], DB [d3837da0, dd574421]
track  9: rip accurate     (max confidence    109) v1 [201b9126], v2 [9c227dad], DB [201b9126, 9c227dad]
track 10: rip accurate     (max confidence    107) v1 [55237ff1], v2 [6deeb4ef], DB [55237ff1, 6deeb4ef]
track 11: rip accurate     (max confidence    107) v1 [1bc70ed4], v2 [3e37074f], DB [1bc70ed4, 3e37074f]
track 12: rip accurate     (max confidence    109) v1 [27618f7c], v2 [05a27ae0], DB [27618f7c, 05a27ae0]
track 13: rip accurate     (max confidence    110) v1 [cee68e7c], v2 [13943b1c], DB [cee68e7c, 13943b1c]
track 14: rip accurate     (max confidence    103) v1 [6ca0fd33], v2 [5adfd465], DB [6ca0fd33, 5adfd465]
track 15: rip accurate     (max confidence    108) v1 [d832b1bb], v2 [cec7db4a], DB [d832b1bb, cec7db4a]
track 16: rip accurate     (max confidence    104) v1 [aa09b693], v2 [af5b422d], DB [aa09b693, af5b422d]
track 17: rip accurate     (max confidence    105) v1 [eb52a7e4], v2 [add1e47e], DB [eb52a7e4, add1e47e]
track 18: rip accurate     (max confidence    105) v1 [045d88e3], v2 [6c177682], DB [045d88e3, 6c177682]
track 19: rip accurate     (max confidence    103) v1 [47b709fa], v2 [7a60d20c], DB [47b709fa, 7a60d20c]
@milkcanworld milkcanworld changed the title Hidden track 0 not written Hidden track 0 not written to disk May 3, 2024
Copy link

github-actions bot commented May 3, 2024

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@milkcanworld milkcanworld changed the title Hidden track 0 not written to disk Short hidden track 0 not written to disk May 3, 2024
@MerlijnWajer
Copy link
Collaborator

Is this due to 31 frames being less than 2 seconds, i.e. the Red Book minimum track time? If so, I wonder if there should be an exception for hidden tracks or something like that, as it's already not exactly a track in the traditional sense.

Yes, there's code in whipper which looks at a track and decides whether it's likely not a HTOA, based on how silent the track is, I believe.

@MerlijnWajer
Copy link
Collaborator

This is in all likelyhood just the pregap of the first track, and not actually HTOA. I don't know if we have a setting to turn off this detection.

@milkcanworld
Copy link
Author

I'm thinking the same, it could be nice to have an option to work around that if desired though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants