Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voterFacebookSaveToCurrentAccount needed for FacebookSignIn #42

Open
DaleMcGrew opened this issue Mar 2, 2021 · 2 comments
Open

voterFacebookSaveToCurrentAccount needed for FacebookSignIn #42

DaleMcGrew opened this issue Mar 2, 2021 · 2 comments
Labels
Verify Fix

Comments

@DaleMcGrew
Copy link
Member

In testing the addition of Facebook sign in to Campaigns, I found one situation where it isn't working. When the email associated with Facebook is not in WeVoteServer database (Email or Voter email), the Facebook sign in fails. If you then sign in with email (using a verification code emailed to you), and sign out, Facebook sign in will work the second time (after the email address has been created in WeVoteServer).

To fix this, when you sign in, we need to support calling the API voterFacebookSaveToCurrentAccount (an alternate to voterMergeTwoAccountsByFacebookKey) in this file: Campaigns/src/js/components/Facebook/FacebookSignIn.jsx

I have pasted in the code (commented out) that was used in WebApp to call this API.
@SailingSteve
Copy link
Member

This is resolved by a prior PR

@SailingSteve SailingSteve mentioned this issue Mar 8, 2021
Merged
@SailingSteve
Copy link
Member

SailingSteve commented Sep 2, 2021 •
edited
Loading

Dale McGrew 5:01 PM
Hi Steve, Facebook sign in works on my local machine on a Campaign URL, yay! It doesn’t seem to be bringing over any information from Facebook though (first/last name, photo, etc.)
I wonder if it is related to voterFacebookSaveToCurrentAccount and/or voterMergeTwoAccountsByFacebookKey mentioned in this: (issue 42)

SailingSteve added a commit to SailingSteve/Campaigns that referenced this issue Sep 2, 2021
@SailingSteve
Facebook name and photo was not saving on first facebook sign-ins
c936078 
Made sure VoterActions.voterFacebookSaveToCurrentAccount() was being
called when appropriate.
Verify that this solves wevote/issues/42
This was referenced Sep 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Verify Fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SailingSteve @DaleMcGrew