Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant module icon declarations #257

Open
fschmenger opened this issue Sep 7, 2021 · 0 comments
Open

Remove redundant module icon declarations #257

fschmenger opened this issue Sep 7, 2021 · 0 comments

Comments

@fschmenger
Copy link
Collaborator

As a consquence of generalizing the Wegue toolbar button implementation in #207, we have to declare the button icon in app-conf as part of the module properties, e.g.

"modules": {
    "wgu-layerlist": {
      "icon": "layers",
      ...
    }
}

The same icon is also used as as the window header icon for the respective module card.
Currently the corresponding window (module-card based) implementations declare a default value for it's icon, e.g. for LayerListWin

props: {
  icon: { type: String, required: false, default: 'layers' }
}

This is redundant and should be removed.

A final question:
Should we should provide a generic fallback for module icons, e.g. https://fonts.google.com/icons?selected=Material+Icons&icon.query=view+module, and make the module icon property optional? Currently the field is mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant