Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Geocoder language options and i18n language detection. #255

Open
fschmenger opened this issue Sep 7, 2021 · 0 comments
Open

Comments

@fschmenger
Copy link
Collaborator

The language specific geocoder providerOptions should be derived from the active language as detected by the util/Locale.js module. Currently geocoder has an app-conf setting may look like the following and is redundant to the global lang definition:

"providerOptions": {
    "key": "",
    "lang": "nl-NL",
    "countrycodes": "nl",
    "limit": 5
  }

This topic is a follow up task to #205 and was discussed in #233.
Quoted from #233:

This requires some sort of mapping between the supported languages and the geocoder language codes.
Where do we want to put the mapping (e.g. configure in the 'lang' property or somewhere specific in 'wgu-geocoder'? I didnt study geocoder code closely enough to know the implications, so any ideas welcome here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant