Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep state, better navigation #261

Open
TobiX opened this issue Apr 10, 2023 · 0 comments
Open

Keep state, better navigation #261

TobiX opened this issue Apr 10, 2023 · 0 comments

Comments

@TobiX
Copy link
Member

TobiX commented Apr 10, 2023

This would probably mean a pretty significant core change. Currently, dosage always starts from the latest comic (or one specified by an ID) and works its way backwards from there. This can lead to the following results:

  • In a perfect world, dosage fetches each strip until it reaches the very first one and then stops. Additional calls to dosage only fetch new images if new strips were added to the end since the last run
  • If dosage was rudely interrupted (network outage, server error, user interrupt), you now have a partial download with a chunk missing in the front. The only way to retrieve these is
    • either run dosage with --all to blindly step over all existing strips in the hope of getting farther this time (wasting time & bandwidth for moving past existing strips)
    • or try to manually find the correct ID to resume from (if possible) and restart dosage with that ID
  • Individual strips might fail to download (images, not the HTML), so now you have gaps in your comic archive and the best way forward is (again) running dosage with --all in the hope of fixing those gaps

Most of those cases could be avoided it dosage kept some state and could be told to "finish" fetching a comic from there... This would also open the way to a more "natural" fetching strategy starting from the first strip of a comic. Over the years I encountered some (hand-written) comics were backward-navigation was plainly broken (because it was never tested) or lead to awkward loops...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant