Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking metrics updates on test regressions #276

Closed
foolip opened this issue Feb 7, 2023 · 4 comments
Closed

Blocking metrics updates on test regressions #276

foolip opened this issue Feb 7, 2023 · 4 comments

Comments

@foolip
Copy link
Member

foolip commented Feb 7, 2023

As discussed in web-platform-tests/results-analysis#143, any new non-OK harness status (for testharness.js tests) will prevent the Interop 2023 scores from updating until that test is added to the list of ignored tests statuses.

This mechanism was inherited from Interop 2022. During 2022, there were no regressions, so we never noticed this.

Unfortunately, web-platform-tests/wpt#38258 broke the score updating for almost a week before @gsnedders alerted me to the fact in web-platform-tests/results-analysis#143 and I just fixed it.

I don't think we have the right tradeoff here, we shouldn't block Interop 2023 updates because a regression in a single test, and we shouldn't require the interop team to triage and fix such regressions.

I think we should:

@foolip foolip added the agenda+ label Feb 7, 2023
@gsnedders
Copy link
Member

The thing that's obvious here is how neither web-platform-tests/wpt#38203 nor web-platform-tests/wpt#38258 failed CI on WPT (see web-platform-tests/wpt#10877).

@foolip
Copy link
Member Author

foolip commented Feb 8, 2023

@gsnedders I didn't confirm it, but assumed based on the timing (~4 hours apart) that both PRs passed the CI separately and were then both merged.

@foolip
Copy link
Member Author

foolip commented Apr 26, 2023

This is blocked on getting review of web-platform-tests/results-analysis#150.

@foolip foolip removed the agenda+ label Apr 26, 2023
@foolip
Copy link
Member Author

foolip commented Feb 15, 2024

Closing this as I won't be driving any changes here. I've closed web-platform-tests/results-analysis#150 but note that web-platform-tests/results-analysis#173 remains open. @jgraham can you file a new issue if you want to move forward with some change?

@foolip foolip closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants