From 45c728d6969af2dbc6c4a7541a8dd88d98b432dd Mon Sep 17 00:00:00 2001 From: "Daniel D. Beck" Date: Tue, 22 Oct 2024 18:48:29 +0200 Subject: [PATCH 1/2] Add checklist for handling BCD upgrades --- .github/workflows/bcd_upgrade_checklist.yml | 29 +++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 .github/workflows/bcd_upgrade_checklist.yml diff --git a/.github/workflows/bcd_upgrade_checklist.yml b/.github/workflows/bcd_upgrade_checklist.yml new file mode 100644 index 00000000000..2f3370e0ca3 --- /dev/null +++ b/.github/workflows/bcd_upgrade_checklist.yml @@ -0,0 +1,29 @@ +name: BCD upgrade + +on: + pull_request: + types: [opened] +jobs: + post-comment: + name: "Post checklist" + runs-on: ubuntu-latest + if: github.event.pull_request.user.login == 'dependabot[bot]' + steps: + - id: dependency + run: | + if ! git diff --exit-code -G '@mdn/browser-compat-data' "${{ github.event.pull_request.base.sha }}" "${{ github.sha }}"; then + echo "is_bcd=true" >> $GITHUB_OUTPUT + fi + exit 0 + - if: ${{ steps.dependency.outputs.is_bcd == 'true' }} + uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 #v4.0.0 + with: + issue-number: ${{ github.event.number }} + body: | + Complete this checklist for every `@mdn/browser-compat-data` upgrade PR: + + - [ ] Check out this branch locally. + - [ ] If any keys were removed in the release, delete them from `.yml` files. + - [ ] Run `npm install && npm run dist && npm run dist && git commit --all --message="Refresh dist"`. + - [ ] Start a PR to [publish the next web-features release](https://github.com/web-platform-dx/web-features/blob/main/docs/publishing.md#regular-releases). + - [ ] Merge this PR. From 89a2d9fd80efcc0db847320e32a397fda361eed8 Mon Sep 17 00:00:00 2001 From: "Daniel D. Beck" Date: Wed, 23 Oct 2024 15:13:16 +0200 Subject: [PATCH 2/2] Add steps added during today's release --- .github/workflows/bcd_upgrade_checklist.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bcd_upgrade_checklist.yml b/.github/workflows/bcd_upgrade_checklist.yml index 2f3370e0ca3..3a9c0070c83 100644 --- a/.github/workflows/bcd_upgrade_checklist.yml +++ b/.github/workflows/bcd_upgrade_checklist.yml @@ -24,6 +24,8 @@ jobs: - [ ] Check out this branch locally. - [ ] If any keys were removed in the release, delete them from `.yml` files. - - [ ] Run `npm install && npm run dist && npm run dist && git commit --all --message="Refresh dist"`. + - [ ] Run `npm install && npm run dist && npm test && git commit --all --message="Refresh dist"`. + - [ ] Review the diff. Watch out for Baseline regressions; if applicable, add a comment (see https://github.com/web-platform-dx/web-features/issues/1971). - [ ] Start a PR to [publish the next web-features release](https://github.com/web-platform-dx/web-features/blob/main/docs/publishing.md#regular-releases). - [ ] Merge this PR. + - [ ] [Trigger a drafts update workflow run](https://github.com/web-platform-dx/web-features/actions/workflows/update_draft_features_weekly.yml).