[PR] Templates #111
Merged
[PR] Templates #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 1, 2017 16:21
I hope this is more sensible, anyhow.
This is for consistency and in preparation of eventually adding filter options for the other taxonomies. I'm not sure what the best label for this filter is - other than definitely not `org` - so I've left them as `unit` for now.
I must have had an idea for a different approach at some point, but only did half the work or something...
For individual profile views only - it seems to make sense to leave it as is for directory page or card shortcode views as there isn't as much space in those cases.
jeremyfelt
approved these changes
Sep 5, 2017
There was a problem hiding this comment.
Looks good! I don't think it fixes #86 yet, but good progress towards it. I'll do a better job of explaining what I'm thinking there. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109, and probably fixes #86 (I'm definitely open to the possibility that it might not :).