From 76905d150321687c7a2be9c3457aa2413f734eed Mon Sep 17 00:00:00 2001 From: Sebastian Date: Sat, 19 Dec 2015 18:36:42 +0100 Subject: [PATCH] update after NOTEs on CRAN --- README.md | 24 +++++++++++++++--------- cran-comments.md | 18 ++++++++++++++++++ vignettes/modulesInR.Rmd | 2 +- 3 files changed, 34 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index a5e24d3..0f06446 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ --- title: "Modules in R" author: "Sebastian Warnholz" -date: "2015-12-18" +date: "2015-12-19" output: rmarkdown::html_vignette vignette: > %\VignetteIndexEntry{Modules in R} @@ -11,7 +11,7 @@ vignette: > [![Build Status](https://travis-ci.org/wahani/modules.png?branch=master)](https://travis-ci.org/wahani/modules) [![codecov.io](https://codecov.io/github/wahani/modules/coverage.svg?branch=master)](https://codecov.io/github/wahani/modules?branch=master) -[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.rstudio.com/package=modules) +[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.r-project.org/package=modules) [![Downloads](http://cranlogs.r-pkg.org/badges/modules?color=brightgreen)](http://www.r-pkg.org/pkg/modules) Provides modules as an organizational unit for source code. Modules enforce to be more rigorous when defining dependencies and have a local search path. They can be used as a sub unit within packages or in scripts. @@ -48,6 +48,13 @@ Typically you do not have to call that function explicitly but instead call ```r library(modules) +``` + +``` +## Loading required package: aoos +``` + +```r m <- module({ boringFunction <- function() cat("boring output") }) @@ -235,12 +242,11 @@ search() ``` ``` -## [1] ".GlobalEnv" "import:module" "import:module" -## [4] "import:module" "package:parallel" "package:modules" -## [7] "package:aoos" "tools:rstudio" "package:stats" -## [10] "package:graphics" "package:grDevices" "package:utils" -## [13] "package:datasets" "package:methods" "Autoloads" -## [16] "package:base" +## [1] ".GlobalEnv" "import:module" "package:parallel" +## [4] "package:modules" "package:aoos" "tools:rstudio" +## [7] "package:stats" "package:graphics" "package:grDevices" +## [10] "package:utils" "package:datasets" "package:methods" +## [13] "Autoloads" "package:base" ``` ```r @@ -319,7 +325,7 @@ clusterMap(cl, m$gen, list(m$NewType(NULL))) ## NULL ## ## attr(,".self") -## +## ## attr(,"class") ## [1] "NewType" "list" ``` diff --git a/cran-comments.md b/cran-comments.md index c663793..b92abf8 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,3 +1,19 @@ + +This is a re-submission of the package, as requested. The reason for the new +submission was the following NOTE in the previous version: + +Found the following (possibly) invalid URLs: + URL: http://www.r-pkg.org/pkg/modules + From: inst/doc/modulesInR.html + Status: 404 + Message: Not Found + URL: https://cran.rstudio.com/package=modules + From: inst/doc/modulesInR.html + Status: 404 + Message: Not Found + +I resolved this by removing the badges from the vignette. + ## Test environments * ubuntu (on travis-ci), R 3.2.3 * win-builder (devel and release) @@ -8,3 +24,5 @@ There were no ERRORs, WARNINGs or NOTEs ## Downstream dependencies There are none, this is the first release. + + diff --git a/vignettes/modulesInR.Rmd b/vignettes/modulesInR.Rmd index 1e4292f..a567ab9 100644 --- a/vignettes/modulesInR.Rmd +++ b/vignettes/modulesInR.Rmd @@ -11,7 +11,7 @@ vignette: > [![Build Status](https://travis-ci.org/wahani/modules.png?branch=master)](https://travis-ci.org/wahani/modules) [![codecov.io](https://codecov.io/github/wahani/modules/coverage.svg?branch=master)](https://codecov.io/github/wahani/modules?branch=master) -[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.rstudio.com/package=modules) +[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.r-project.org/package=modules) [![Downloads](http://cranlogs.r-pkg.org/badges/modules?color=brightgreen)](http://www.r-pkg.org/pkg/modules) ```{r, results='asis', echo=FALSE}