Powers of two multiples gadget implemented for Twisted Edwards Curves #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to ark-transcript
…ts still needs to be fixed)
- Clean up linearization test.
Cond Add extendend with TE
|
Ok, i finally noticed it |
davxy
requested changes
Nov 6, 2024
|
@drskalman @swasilyev is there any blocker? |
|
Please repeat wo reformatting all the code. Also there s no need in a trait for te/sw gadgets. The circuit knows in which form the data is. |
|
Or first reformat, add the formatting rules to the ci, then send the pr |
davxy
reviewed
Dec 4, 2024
| (x1 - x2) * (x1 - x2) * (x1 + x2 + x3) | ||
| - (y2 - y1) * (y2 - y1) | ||
| ) + (F::one() - b) * (y3 - y1); | ||
| let mut c1 = b * ((x1 - x2) * (x1 - x2) * (x1 + x2 + x3) - (y2 - y1) * (y2 - y1)) |
There was a problem hiding this comment.
Here I don't know if @swasilyev wants to maintain its formatting
|
Still not adequate for review. The traits have to be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35