Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ObservableProperty, ActuatableProperty #237

Closed
dr-shorthair opened this issue Jul 30, 2024 · 8 comments · Fixed by #249
Closed

Deprecate ObservableProperty, ActuatableProperty #237

dr-shorthair opened this issue Jul 30, 2024 · 8 comments · Fixed by #249

Comments

@dr-shorthair
Copy link
Collaborator

Only sosa:Property is needed.
No functional difference between the sub-classes.
Legacy sub-class relationships in ssn-deprecated.ttl would preserve backward compatibility.

See argument here: #235 (comment)

@dr-shorthair
Copy link
Collaborator Author

@alexrobin @KathiSchleidt @ldesousa any comment on this?

@ldesousa
Copy link
Contributor

I am in favour of this change.

@dr-shorthair
Copy link
Collaborator Author

Kathi also agreed earlier
2024-09-25 telecon agreed with this.

@sgrellet
Copy link
Contributor

fine with me as well

@alexrobin
Copy link
Collaborator

I support this as well

@dr-shorthair
Copy link
Collaborator Author

@alexrobin @sgrellet could you review #249 please?

@alexrobin
Copy link
Collaborator

The only thing I noticed is this part of the documentation of Actuator that I don't think is necessary anymore:

Restriction: sosa:forProperty ONLY sosa:Property

Same thing in the RDF:

sosa:Actuator 
  rdfs:subClassOf sosa:System ;
  rdfs:subClassOf [ a owl:Restriction ; owl:onProperty sosa:forProperty ; owl:allValuesFrom sosa:Property ] ;

However, should the Actuator class have a restriction on the new actsOn property though?

Otherwise, it looks good to me.

@dr-shorthair
Copy link
Collaborator Author

Right. That restriction is 'inherited' from the parent class sosa:System.
Also missed similar on sosa:Sensor.
Fixed now.

@alexrobin @sgrellet could you approve review so it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants