Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus::daemon::real_download_url should allow empty string #225

Open
TheMeier opened this issue Jun 29, 2018 · 1 comment
Open

prometheus::daemon::real_download_url should allow empty string #225

TheMeier opened this issue Jun 29, 2018 · 1 comment
Assignees

Comments

@TheMeier
Copy link
Collaborator

TheMeier commented Jun 29, 2018

prometheus::daemon::real_download_url is not used when install_method is 'package'
it should be optional in prometheus::daemon and the prometheus::*_exporter classes

@bramblek1
Copy link

bramblek1 commented Nov 22, 2018

I would argue this type safety should be left to the archive resource that gets the file.

When using prometheus::daemon to add non-standard exporters which are already installed, I have used a workaround.

install_method: "none"
real_download_url: "http://nowhere/"

It would also be great to be able to provide a file:// url which would be useful for environments where network access is restrictive.

edit - change provider to install_method in example; spelling

@TheMeier TheMeier self-assigned this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants