Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI plugins for Consul connect #24

Open
akshatgit opened this issue Oct 23, 2020 · 4 comments
Open

CNI plugins for Consul connect #24

akshatgit opened this issue Oct 23, 2020 · 4 comments

Comments

@akshatgit
Copy link

Just wanted to know if this is in pipeline. We want to use Consul connect and for this, there is a requirement for CNI plugins installation on Nomad.
Ref: https://www.nomadproject.io/docs/integrations/consul-connect

Thanks
Akshat

@spuder
Copy link

spuder commented Nov 2, 2020

I don't think the CNI plugin should be included in this module. We use a role/profile module to manage the nomad module and then install the cni plugins separatley

  class { '::nomad':
    version     => $version,
    config_hash => deep_merge($config_hash,$config)
  }

  file { '/opt/cni':
    ensure => directory,
    owner => 'nomad',
    group => 'nomad',
  } ->
  file { '/opt/cni/bin':
    ensure => directory,
    owner => 'nomad',
    group => 'nomad',
  } ->
  archive { 'cni-plugins':
    path => '/tmp/cni-plugins.tgz',
    source => 'https://github.com/containernetworking/plugins/releases/download/v0.8.5/cni-plugins-linux-amd64-v0.8.5.tgz',
    extract => true,
    extract_path => '/opt/cni/bin/',
    cleanup => true,
    creates => '/opt/cni/bin/flannel'
  }

@akshatgit
Copy link
Author

Hi @spuder, thanks for sharing this. This looks like a good workaround. But I still think we should include it in the module. Systems where we require cni plugins, we can just include it. If you think this is not required, please close this issue.

Thanks,
Akshat

@attachmentgenie
Copy link
Member

personally i have it install from a profile as well, however i do feel there might be a place for it in this module however. But in a separate class and or behind a feature switch

@maxadamo
Copy link
Contributor

maxadamo commented Mar 11, 2023

@attachmentgenie , @akshatgit @spuder , please have a look onto this one: https://github.com/GEANT/nomad_cni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants