From 09d0b4d1f181e115ecc1c441c36fa426f6b27804 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Tue, 30 Apr 2024 13:54:48 +0200 Subject: [PATCH] fail if datacenter/datastore could not be found This is based on some manual testing and https://github.com/ManageIQ/rbvmomi2?tab=readme-ov-file#usage. previously we ignored this failure case which results in a nilclass exception somewhere else. --- lib/beaker/hypervisor/vsphere_helper.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/beaker/hypervisor/vsphere_helper.rb b/lib/beaker/hypervisor/vsphere_helper.rb index 7331374..02b5b04 100644 --- a/lib/beaker/hypervisor/vsphere_helper.rb +++ b/lib/beaker/hypervisor/vsphere_helper.rb @@ -106,8 +106,8 @@ def find_vms(names, connection = @connection) end def find_datastore(dc, datastorename) - datacenter = @connection.serviceInstance.find_datacenter(dc) - datacenter.find_datastore(datastorename) + datacenter = @connection.serviceInstance.find_datacenter(dc) || raise("datacenter #{dc} not found") + datacenter.find_datastore(datastorename) || raise("datastore #{datastorename} not found") end def find_folder(dc, foldername)