Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows.pstree output too much data. Support hiding columns #1302

Closed
atcuno opened this issue Oct 8, 2024 · 3 comments · Fixed by #1304
Closed

windows.pstree output too much data. Support hiding columns #1302

atcuno opened this issue Oct 8, 2024 · 3 comments · Fixed by #1304
Assignees

Comments

@atcuno
Copy link
Contributor

atcuno commented Oct 8, 2024

The existing windows.pstree plugin is currently unusable from the command line as it reports the path multiple times and line wraps (even multiple wraps in many instances) for every single process. Even with the smallest of fonts, it still wraps each process at least once to a new line.

The main intended purpose of pstree is to let users visually see the parent/child relationship, which right now does not work at all.

Since pstree has been merged in this form for a while, we want to know what the best way forward is to get a reasonable output that users can visually see the parent/child relationship.

Potential options:

  1. Remove all the unneeded columns from the existing pstree, and then version bump as needed.

  2. Make something like a --minimal flag to pstree that only reports necessary columns and that won't wrap. But from the past, I don't think these options were viewed well.

  3. Make a windows.pstree_minimal new plugin that reports the tree with just the columns needed for further analysis and that won't wrap. Implementing this would be very trivial.

Thoughts @ikelos ? I am leaning towards 3 in terms of not breaking existing flows, but even with that, the current pstree is completely unusable, and we would have to teach students not to use it and always run pstree_minimal instead to get usable results.

@ikelos
Copy link
Member

ikelos commented Oct 8, 2024

Sounds like we just need to get #1085 across the line?

@ikelos
Copy link
Member

ikelos commented Oct 8, 2024

I clearly had my hesitations about the tack I took, so I'll need to revisit it and see if I can figure out what made me uneasy about it. I think it was the request to allow plugins to define what their own default columns to display was... I should be able to rip it down to just the user deciding though, that should be straightforward and problem free.

@atcuno
Copy link
Contributor Author

atcuno commented Oct 8, 2024

Yes, that would solve it all. Perfect

@ikelos ikelos linked a pull request Oct 8, 2024 that will close this issue
@ikelos ikelos changed the title windows.pstree is unusable from reporting the path so many times. How to fix? windows.pstree output too much data. Support hiding columns Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants