Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lease stealing code exception #100

Open
dengblog opened this issue Dec 10, 2021 · 3 comments
Open

Lease stealing code exception #100

dengblog opened this issue Dec 10, 2021 · 3 comments

Comments

@dengblog
Copy link

1639131792488_5DE9572C-4145-4d34-9284-D13083D144FD

During the lease theft test, I found that the theft was abnormal. Originally, a work could only steal one lease at a time, but there was a problem of stealing multiple leases here. By checking the code, I found some problems in the following codes

demo

In the code, in order to ensure that only one lease is stolen at a time, if there is a claimrequest, it will not be stolen again. The problem is that there is no assignment to claimrequest, and the value of claimrequest is not stored in the local shard. The judgment is always false.

@fafg
Copy link
Contributor

fafg commented Jan 5, 2022

hi @dengblog

145558993-724a69bc-de55-4440-9773-40e43ca1bff4

I believe the expected result after the rebalance should be something like this, right? 👆

@dengblog
Copy link
Author

hi @fafg
image

The expected result should be like this, but there is something wrong with the implementation process, which may cause all assignto to be "hello"

@cmckelvey-vmware
Copy link
Contributor

This is a good catch. I can take this and start working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants